Skip to content

Allow eta expansion during inlining #11629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Mar 6, 2021

Fixes #11628

@nicolasstucki nicolasstucki merged commit 7f17a05 into scala:master Mar 8, 2021
@nicolasstucki nicolasstucki deleted the fix-11628 branch March 8, 2021 10:58
@smarter
Copy link
Member

smarter commented Mar 8, 2021

This PR appears to have broken the non-bootstrapped tests (https://github.com/lampepfl/dotty/runs/2055839734):

Compilation failed for: 'tests/pos/i11628'                                      
-- Error: tests/pos/i11628/main.scala:4:18 -----------------------------------------------------------------------------
4 |  summonConversion()
  |  ^^^^^^^^^^^^^^^^^^
  |  Exception occurred while executing macro expansion.
  |  java.lang.Exception: non-bootstrapped-lib
  |  	at scala.quoted.Type.<init>(Type.scala:9)
  |  	at scala.quoted.runtime.impl.TypeImpl.<init>(TypeImpl.scala:7)
  |  	at scala.quoted.runtime.impl.QuotesImpl.unpickleType(QuotesImpl.scala:2891)
  |  	at macros$package$.summonConversionImpl(macros.scala:13)
  |
  | This location contains code that was inlined from main.scala:4

inlined at main.scala:4:

@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implicit search assertion failed in macro, in combination with implicits defined in Scala 2
4 participants